This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH, MIPS] When calculating a relocation using an undefined weak symbol don't check for overflow.
- From: Andrew Bennett <Andrew dot Bennett at imgtec dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>, "Tristan Gingold (gingold at adacore dot com)" <gingold at adacore dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 2 Dec 2014 13:40:03 +0000
- Subject: RE: [PATCH, MIPS] When calculating a relocation using an undefined weak symbol don't check for overflow.
- Authentication-results: sourceware.org; auth=none
- References: <0DA23CC379F5F945ACB41CF394B9827720F35D28 at LEMAIL01 dot le dot imgtec dot org> <87fvczuhxz dot fsf at googlemail dot com>
> > bfd/
> > * elfxx-mips.c (mips_elf_calculate_relocation): Only check for overflow
> > on non-weak undefined symbols.
> >
> > ld/testsuite/
> > * ld-mips-elf/mips-elf.exp: Add in undefined weak overflow tests for
> > o32, n32 and n64.
> > * ld-mips-elf/undefweak-overflow.s: New test.
> > * ld-mips-elf/undefweak-overflow.d: New test.
> > * ld-mips-elf/undefweak-overflow-n64.d: New test.
> > * ld-mips-elf/undefweak-overflow-n64.d: New test.
>
> OK, thanks, and sorry for the slow reply.
That's ok. I have now committed the patch.
Tristan: Would it be ok to backport the patch onto the binutils 2.25 branch?
Many thanks,
Andrew