This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PPC gold doesn't check for overflow properly


>> +    Status stat = This::template rela<32,26>(view, 0, 0x03fffffc,
>> +                                            value, overflow);
>>
>> Given the right shift, shouldn't that be 24?
>
> No.  The right shift here is 0.  The field has 24 bits (hence the
> name), but the bottom 2 bits of the value are masked.  So the range is
> that for a signed 26-bit multiple of four.

Oh, yeah. Duh. I have no idea where I got the idea that the shift was 2.

Thanks for the quick fixes!

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]