This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
- From: Alan Modra <amodra at gmail dot com>
- To: Victor Kamensky <victor dot kamensky at linaro dot org>
- Cc: binutils at sourceware dot org, Andrew Pinski <pinskia at gmail dot com>
- Date: Thu, 23 Oct 2014 09:20:53 +1030
- Subject: Re: [PATCH V2] ARM: plt_size functions need to read instructions in right byte order
- Authentication-results: sourceware.org; auth=none
- References: <1413955513-4923-1-git-send-email-victor dot kamensky at linaro dot org> <1413955513-4923-2-git-send-email-victor dot kamensky at linaro dot org>
On Tue, Oct 21, 2014 at 10:25:13PM -0700, Victor Kamensky wrote:
> + if ((elf_elfheader (abfd)->e_flags) & EF_ARM_BE8)
^ this parenthesis is in the
wrong place. gcc will warn about "if (x & y)", breaking -Werror
builds. Writing "if ((x & y))" silences the gcc warning, so you
should write
if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8))
or as I suggested in the previous email (without explaining why)
if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8) != 0)
The patch is OK to commit with that change.
--
Alan Modra
Australia Development Lab, IBM