This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V2] ARM: plt_size functions need to read instructions in right byte order


On Tue, Oct 21, 2014 at 10:25:13PM -0700, Victor Kamensky wrote:
> +  if ((elf_elfheader (abfd)->e_flags) & EF_ARM_BE8)
                                       ^ this parenthesis is in the
wrong place.  gcc will warn about "if (x & y)", breaking -Werror
builds.  Writing "if ((x & y))" silences the gcc warning, so you
should write

  if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8))

or as I suggested in the previous email (without explaining why)

  if ((elf_elfheader (abfd)->e_flags & EF_ARM_BE8) != 0)

The patch is OK to commit with that change.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]