This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][aarch64]Patch for Relaxation
- From: Ryan Mansfield <rmansfield at qnx dot com>
- To: <binutils at sourceware dot org>
- Date: Thu, 16 Oct 2014 11:24:02 -0400
- Subject: Re: [gold][aarch64]Patch for Relaxation
- Authentication-results: sourceware.org; auth=none
- References: <CACkGtrhqMpo-Fdt+39XJTLTjjJtz3essmdDEdQY8Owni66sgkw at mail dot gmail dot com> <CAHACq4q2f3bhz4tWHMbz1zLbGDskopaomqveTn_A0ZjwXcBH4Q at mail dot gmail dot com> <CACkGtrjxw9d9GRmiz=ztCne6n8+Dv17jegM45db7HkMLUmy2Qw at mail dot gmail dot com> <CAHACq4rWadE1fDRMZOmqZ4Mr1Qago25a_cd9+u04y9M0b691ug at mail dot gmail dot com> <CACkGtrgoWM8f1Oc71nVTGDrNztCt0BCx1-FiQavn=QOLpZ4tnA at mail dot gmail dot com> <CAHACq4q6_XqUx9ObfG-TZLzAzh_-6L+K45osA_KJ2rTLdvQs6g at mail dot gmail dot com>
On 14-10-15 05:05 PM, Cary Coutant wrote:
Hi Cary, thanks. Attached the updated patch.
The only diff from patch2 is the "hash_value" functionï which I
directly pasted below for ease of review.
Thanks! This is OK to commit.
I noticed that this change doesn't build with gcc 4.2.
g++ -DHAVE_CONFIG_H -I. -I../../gold -I../../gold
-I../../gold/../include -I../../gold/../elfcpp
-DLOCALEDIR="\"/usr/local/share/locale\"" -DBINDIR="\"/usr/local/bin\""
-DTOOLBINDIR="\"/usr/local/arm-linux-gnueabi/bin\""
-DTOOLLIBDIR="\"/usr/local/arm-linux-gnueabi/lib\"" -W -Wall
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -frandom-seed=aarch64.o -g
-O2 -MT aarch64.o -MD -MP -MF .deps/aarch64.Tpo -c -o aarch64.o
../../gold/aarch64.cc
../../gold/aarch64.cc: In static member function 'static
bool<unnamed>::AArch64_relocate_functions<size,
big_endian>::maybe_apply_stub(unsigned int, const
gold::Relocate_info<size, big_endian>*, const elfcpp::Rela<size,
big_endian>&, unsigned char*, typename
elfcpp::Elf_types<size>::Elf_Addr, const gold::Sized_symbol<size>*,
const gold::Symbol_value<size>*, const gold::Sized_relobj_file<size,
big_endian>*)':
../../gold/aarch64.cc:4096: error: expected `;' before 'status'
../../gold/aarch64.cc:4098: error: 'status' was not declared in this scope
<snip>
I'm not aware of a documented required g++ version for binutils/gold. Is
there? I looked around but didn't find anything.
Regards,
Ryan Mansfield