This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

On 09/22/2014 09:53 PM, Joel Brobecker wrote:
>>>> The related warning under Darwin x86_64:
>>>>   gcc -c -DHAVE_CONFIG_H    -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
>>>>   ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
>>>>     rl_message ("%s", p, 0);
>>>>                 ~~~~     ^
>>>>   1 warning generated.
>>>> readline/ChangeLog.gdb:
>>>> 	* search.c (_rl_nsearch_init): Remove useless parameter '0' for
>>>> 	rl_message().
>>> Because readline is a separate project from binutils/GDB, we prefer
>>> it if you would first submit the patch to the readline project first
>>> (, in Cc: of this email), get it accepted there.

OK, thanks, next I shall cc, when send new patch
for readline.

>> This bug was already fixed in bash 4.3.
> I see! Sorry about the noise.

At least, what you orginally said is useful to me. :-)

And excuse me, my English is not quite well, I am not quite understand
the meaning: "... taking the lead in telling us ...", could you explain
about it in details?


>                               For my penance, I pushed the patch in.
> Do we need it for 7.8.1 as well?

Chen Gang

Open share and attitude like air water and life which God blessed

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]