This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()
- From: Andreas Schwab <schwab at suse dot de>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Chen Gang <gang dot chen dot 5i5j at gmail dot com>, bug-readline at gnu dot org, amodra at gmail dot com, Pedro Alves <palves at redhat dot com>, jan dot kratochvil at redhat dot com, drow at false dot org, ezannoni at kwikemart dot cygnus dot com, muller at sourceware dot org, Nicholas Clifton <nickc at redhat dot com>, gdb-patches at sourceware dot org, binutils at sourceware dot org, macro at linux-mips dot org
- Date: Mon, 22 Sep 2014 15:06:50 +0200
- Subject: Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()
- Authentication-results: sourceware.org; auth=none
- References: <541CF976 dot 8090905 at gmail dot com> <20140922130324 dot GA4883 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> writes:
> Hi Chen,
>
>> The related warning under Darwin x86_64:
>>
>> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
>> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
>> rl_message ("%s", p, 0);
>> ~~~~ ^
>> 1 warning generated.
>>
>>
>> readline/ChangeLog.gdb:
>>
>> * search.c (_rl_nsearch_init): Remove useless parameter '0' for
>> rl_message().
>
> Because readline is a separate project from binutils/GDB, we prefer
> it if you would first submit the patch to the readline project first
> (bug-readline@gnu.org, in Cc: of this email), get it accepted there.
This bug was already fixed in bash 4.3.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."