This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][MIPS] Cleanup expected output for several MIPS targets

Matthew Fortune <> writes:
> Attached is a testsuite-only patch to ensure all the tests added in the
> MIPS O32 FPXX patch will pass on all MIPS targets.
> This probably amounts to an obvious fix even though it is quite large
> but I would like to double check the changes I made to the mips.exp and
> mips-elf.exp files are OK.

Not sure about the obviousness :-)  There seem to be several different
types of change here.  Please could you split the patch up so that there's
one type of change per patch?  E.g. adding extra sections is simple enough,
but it's less obvious that:

diff --git a/gas/testsuite/gas/mips/attr-gnu-abi-fp-1.d b/gas/testsuite/gas/mips/attr-gnu-abi-fp-1.d
index ce5bbc2..17218d3 100644
--- a/gas/testsuite/gas/mips/attr-gnu-abi-fp-1.d
+++ b/gas/testsuite/gas/mips/attr-gnu-abi-fp-1.d
@@ -9,14 +9,14 @@ File Attributes
 MIPS ABI Flags Version: 0
 GPR size: 32
 CPR1 size: 32
 CPR2 size: 0
 FP ABI: Hard float \(double precision\)
-ISA Extension: None
+ISA Extension: .*
-FLAGS 1: 00000000
+FLAGS 1: 0000000.
 FLAGS 2: 00000000
is a good idea, since in some ways it weakens the test.  Another option
would be to force MIPS I on the command line.

The mips.exp change is OK as a stand-alone patch.

Why is:

@@ -60,7 +60,7 @@ set linux_gnu [expr [istarget mips*-*-linux*]]
 set embedded_elf [expr [istarget mips*-*-elf]]
 # Set defaults.
-set abi_asflags(o32) ""
+set abi_asflags(o32) "-32"
 set abi_asflags(n32) "-march=from-abi -n32 -EB"
 set abi_asflags(n64) "-march=from-abi -64 -EB"
 set abi_ldflags(o32) ""

needed now and not before?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]