This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/gas: LQC2, LDC3 and SQC2 macro !microMIPS assertions


"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> Hi,
>
>  This adds missing !microMIPS assertions for the LQC2, LDC3 and SQC2 
> macros whose underlying instructions have no microMIPS encoding.

I don't really see the need for these kinds of asserts.  If the instruction
isn't available we're going to assert later anyway.  The problem with asserting
here too is that (as this patch proves) it's very hard to maintain the
consistent duplication of information without some kind of automatic help.

I'd prefer to go for consistency the other way and remove
!mips_opts.micromips asserts that are only there because there's no
underlying microMIPS instruction.  This includes the one in the earlier
SAA(D) patch.

Thanks,
Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]