This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Change to Thumb symbol readelf output

Hi Nick,

I noticed this commit:

commit 13761a1136a46a4dec5d01e00743e8b267a23c0d
Author: Nick Clifton <>
Date:   Thu May 2 21:06:15 2013 +0000

        * archures.c: Add some more MSP430 machine numbers.
        * config.bfd (msp430): Define targ_selvecs.
        * Add bfd_elf32_msp430_ti_vec.
        * cpu-msp430.c: Add some more MSP430 machine numbers.
        * elf32-msp430.c Add support for MSP430X relocations.
        Add support for TI compiler generated relocations.
        Add support for sym_diff relocations.
        Add support for relaxing out of range short branches into long
        Add support for MSP430 attribute section.
        * reloc.c: Add MSP430X relocations.
        * targets.c: Add bfd_elf32_msp430_ti_vec.
        * bfd-in2.h: Regenerate.
        * configure: Regenerate.
        * libbfd.h: Regenerate.

        * readelf.c: Add support for MSP430X architecture.

Changes how readelf outputs some thumb symbols:

@@ -8994,8 +9050,13 @@ get_symbol_type (unsigned int type)
       if (type >= STT_LOPROC && type <= STT_HIPROC)
-         if (elf_header.e_machine == EM_ARM && type == STT_ARM_TFUNC)
-           return "THUMB_FUNC";
+         if (elf_header.e_machine == EM_ARM)
+           {
+             if (type == STT_ARM_TFUNC)
+               return "THUMB_FUNC";
+             if (type == STT_ARM_16BIT)
+               return "THUMB_LABEL";
+           }

Was this change intended?

I think it causes a test to fail for arm-linux and I am not sure
whether the best course of action.


Will Newton
Toolchain Working Group, Linaro

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]