This is the mail archive of the
mailing list for the binutils project.
Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()
- From: Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- To: chet dot ramey at case dot edu, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: palves at redhat dot com, gdb-patches at sourceware dot org, binutils at sourceware dot org, bug-readline at gnu dot org, amodra at gmail dot com
- Date: Thu, 19 Jun 2014 09:31:35 +0800
- Subject: Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()
- Authentication-results: sourceware.org; auth=none
- References: <5397C077 dot 1080702 at gmail dot com> <53A1F78A dot 8020508 at case dot edu>
On 06/19/2014 04:33 AM, Chet Ramey wrote:
> On 6/10/14, 10:35 PM, Chen Gang wrote:
>> For regular file, write() operation may also fail, so check it too. If
>> write() return 0, can simply wait and try again, it should not suspend
>> infinitely if environments have no critical issues.
> Readline-6.3 checks the return value from write() and returns a non-zero
> value to the history_truncate_file caller. I really don't think that
> waiting forever if write continues to return 0 is a great idea; an error
> return is enough to let the caller deal with it.
That sounds fine to me, and I will send patch v2 for it. And excuse me,
I have to do some other things today, so I shall try to send it within 2
days (within 2014-06-21) -- if it is too late, please help send it.
Open, share, and attitude like air, water, and life which God blessed