This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] readline/util.c: use '%d' instead of 'ld' to avoid compiling warning

On 05/30/2014 10:15 AM, Alan Modra wrote:
> On Fri, May 30, 2014 at 08:11:41AM +0800, Chen Gang wrote:
>> getpid() will return 'pid_t' which is always 'int', so need use '%d'
>> instead of '%ld' in sprintf().
> Please do not copy many lists and/or maintainers.  This patch should
> have gone just to, since readline belongs
> to the gdb project.
> Also, gdb and binutils generally require patches to be supplied with a
> ChangeLog entry.  See other posts on the mailing list.

OK, thanks.

If we have a tool to tell members (especially new members) the related
mailing addresses (e.g. "scripts/" under Linux kernel
and/or Qemu), that will be cool!

> Now, on to the substance of your patch.  It's wrong to claim that
> "pid_t" is always "int".  I know of systems that use or used to use
> "short".  In fact
> says
> "The implementation shall support one or more programming environments
> in which the widths of blksize_t, pid_t, size_t, ssize_t, and
> suseconds_t are no greater than the width of type long."
> So the correct patch would be to cast the return of getpid() to long,
> continuing to use '%ld' in the format string.

That sounds fine to me.

Please help integrate it into mainline. If need me send patch v2, please
let me know (no reply means "will integrate the correct fix into
mainline by maintainers directly").

Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]