This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ld/ldlang.h: use 'etree_base' instead of 'base' to avoid cross-compiling warning

Firstly, thank you for replying quickly, and it is my first time to send
patch to binutils, and I shall continue.

On 05/24/2014 11:30 PM, Alan Modra wrote:
> On Sat, May 24, 2014 at 07:34:49PM +0800, Chen Gang wrote:
>> It is not recommend to use a simple name to express a global variable,
>> for it is easy to get '-Wshadow'. So use 'etree_base' instead of.
> Better, move base into mri.c.
>     	* ldlang.c (base): Move variable to..
>     	* mri.c:, and make static.
>     	* ldlang.h (base): Delete declaration.

It sounds reasonable to me, but still recommend to use 'etree_base'
instead of 'base' (it is still a global variable within "ld/mri.c").

BTW, the subject of the original message (sent by me) is not precise,
need use "ld: mri:" instead of "ld/ldlang.h:".

If still necessary to let me send patch v2 for it, please let me know.

Chen Gang

Open, share and attitude like air, water and life which God blessed

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]