This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Record whether an object attribute is actually set

Richard Sandiford <> writes:
> Richard Sandiford <> writes:
> > Sorry the slow reply to this.
> >
> > Alan Modra <> writes:
> >> On Mon, May 12, 2014 at 11:22:13PM +0000, Matthew Fortune wrote:
> >>> --- a/bfd/elf-bfd.h
> >>> +++ b/bfd/elf-bfd.h
> >>> @@ -1472,6 +1472,7 @@ typedef struct obj_attribute
> >>>    int type;
> >>>    unsigned int i;
> >>>    char *s;
> >>> +  bfd_boolean is_set;
> >>>  } obj_attribute;
> >>
> >> Note that, because someone added a 2 * 71 array of this struct to
> >> elf_obj_data, all ELF object BFDs get hit by any increase here,
> >> whether the files use attributes or not.  Can you do without the flag,
> >> somehow?
> >
> > Yeah, I was more thinking about having a flag in the assembler,
> > since I think we want to know whether the attribute has been set
> > by an explicit .gnu_attribute in the code, rather than through
> > some implicit setting.
> >
> > How about the attached look?
> Er, that's what happens you change your mind between "how does the
> attached look" and "how about the attached" half-way through the sentence.

At least it didn't turn into complete gibberish which I'm sure I'll
manage one day!

Sorry for not getting back to you sooner, I wanted to run it with the FPXX
tests and had a half broken testsuite as I was working on it. This looks
good. I don't think there was much value in the end in the flag being
stored directly in the attributes as its meaning would have been fuzzy at
link time.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]