This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: PR gold/16945: Executable with -fpie and -mcmodel=large gives segfault on start
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Cc: ccoutant at google dot com
- Date: Thu, 15 May 2014 10:31:29 -0700
- Subject: PATCH: PR gold/16945: Executable with -fpie and -mcmodel=large gives segfault on start
- Authentication-results: sourceware.org; auth=none
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
There are 2 issues:
1. Since the GOT offset is always negative, we need to use signed int
to support 64-bit GOT relocations.
2. R_X86_64_PLTOFF64 uses the address of GLOBAL_OFFSET_TABLE, which is
the address of the .got.plt section, not the .got section.
This patch fixes both. OK for master and 2.24 branch?
Thanks.
H.J.
---
2014-05-15 H.J. Lu <hongjiu.lu@intel.com>
PR gold/16945
* x86_64.cc (Target_x86_64::Relocate::relocate): Use signed int
for got_offset. Properly get GOT address for R_X86_64_PLTOFF64.
diff --git a/gold/x86_64.cc b/gold/x86_64.cc
index 479fb42..f58c843 100644
--- a/gold/x86_64.cc
+++ b/gold/x86_64.cc
@@ -3327,7 +3327,9 @@ Target_x86_64<size>::Relocate::relocate(
// We need to subtract the size of the GOT section to get
// the actual offset to use in the relocation.
bool have_got_offset = false;
- unsigned int got_offset = 0;
+ // Since the actual offset is always negative, we use signed int to
+ // support 64-bit GOT relocations.
+ int got_offset = 0;
switch (r_type)
{
case elfcpp::R_X86_64_GOT32:
@@ -3430,7 +3432,8 @@ Target_x86_64<size>::Relocate::relocate(
gold_assert(gsym->has_plt_offset()
|| gsym->final_value_is_known());
typename elfcpp::Elf_types<size>::Elf_Addr got_address;
- got_address = target->got_section(NULL, NULL)->address();
+ // This is the address of GLOBAL_OFFSET_TABLE.
+ got_address = target->got_plt_section()->address();
Relocate_functions<size, false>::rela64(view, object, psymval,
addend - got_address);
}