This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix alignment for the first section frag on xtensa

On Tue, Apr 22, 2014 at 9:01 PM, Sterling Augustine
<> wrote:
> On Tue, Apr 22, 2014 at 10:00 AM, Sterling Augustine
> <> wrote:
>> foo.s
>> .text
>> .align 8
>> ....//lots of code requiring relaxation
>> //some kind of padding that doesn't include actual text, but can be
>> adjusted by relaxation
>> bar.s
>> .global bar
> Rats: should be another line here:
> // some additional padding similar to the padding that ended bar.

'That ended foo' I suppose? I wouldn't expect bar: label to be aligned
if there's
something going before it other than the .align directive.

>> //some code to ensure the current frag is closed.
>> bar:
>> .align 16 (should be greater than foo's alignment, and applies to the
>> entire section.)
>> I'd need to play with it a bit to get the details right.
>> The patch only applies to the frag where the alignment directive appears.
>> And, of course, I haven't written Xtensa code in years, so I may be
>> missing something.

BTW I've checked the fix in.

-- Max

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]