This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fix 16846, LTO mismatched TLS reference
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Wed, 16 Apr 2014 19:14:46 +0930
- Subject: Fix 16846, LTO mismatched TLS reference
- Authentication-results: sourceware.org; auth=none
I think this is all we need to fix pr16848. HJ, do you see anything
more we should do here? I'm wondering why we have type_change_ok
when oldbfd is the plugin.
PR 16848
* elflink.c (_bfd_elf_merge_symbol): Ignore TLS mismatch when
current bfd is a plugin.
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 3de00e1..9848dc2 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -1108,6 +1108,8 @@ _bfd_elf_merge_symbol (bfd *abfd,
/* Plugin symbol type isn't currently set. Stop bogus errors. */
if (oldbfd != NULL && (oldbfd->flags & BFD_PLUGIN) != 0)
*type_change_ok = TRUE;
+ else if ((abfd->flags & BFD_PLUGIN) != 0)
+ ;
/* Check TLS symbol. We don't check undefined symbol introduced by
"ld -u". */
--
Alan Modra
Australia Development Lab, IBM