This is the mail archive of the
mailing list for the binutils project.
Re: [patch,avr] device specific instruction support for avr devices
- From: Denis Chertykov <chertykov at gmail dot com>
- To: "S, Pitchumani" <Pitchumani dot S at atmel dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Sat, 29 Mar 2014 09:54:57 +0400
- Subject: Re: [patch,avr] device specific instruction support for avr devices
- Authentication-results: sourceware.org; auth=none
- References: <CAC140656783604CABA6AE60C2A6D5A46ADED349 at penmbx01> <CAC140656783604CABA6AE60C2A6D5A46AE13B14 at penmbx01> <CADOs=zZFb7rzC4teAXckz4s0Wz4SqW3Qn+Q8zxNn0tfJcn9fsg at mail dot gmail dot com> <CAC140656783604CABA6AE60C2A6D5A46AE15904 at penmbx01>
2014-03-27 9:07 GMT+04:00 S, Pitchumani <Pitchumani.S@atmel.com>:
>> -----Original Message-----
>> From: Denis Chertykov [mailto:firstname.lastname@example.org]
>> Sent: Tuesday, March 25, 2014 10:37 PM
>> To: S, Pitchumani
>> Cc: email@example.com
>> Subject: Re: [patch,avr] device specific instruction support for avr
>> 2014-03-24 12:23 GMT+04:00 S, Pitchumani <Pitchumani.S@atmel.com>:
>> >> -----Original Message-----
>> >> From: firstname.lastname@example.org [mailto:binutils-
>> >> On Behalf Of S, Pitchumani
>> >> Sent: Monday, March 03, 2014 11:21 AM
>> >> To: email@example.com
>> >> Cc: firstname.lastname@example.org
>> >> Subject: [patch,avr] device specific instruction support for avr
>> >> Hi,
>> >> Few AVR Xmega devices have specific instruction support than the
>> >> architecture
>> >> it belongs to. For example atxmega128b1 device has RMW instructions
>> >> (XCH,LAC,
>> >> LAS and LAT) support, but not all avrxmega6 devices have.
>> >> Now, avr-gcc passes architecture name to assembler instead of device
>> >> So,
>> >> RMW instructions are not recognized (illegal opcode error) by
>> >> I have attached a patch to address this issue in assembler.
>> >> - It adds a option '-mrmw' to assembler.
>> >> - Based on -mrmw option device specific instructions are added to
>> >> instruction set (mcu_types[i].isa | AVR_ISA_RMW)
>> >> Now assembler can recognize rmw instructions for respective devices.
>> >> It is necessary to update gcc to pass -mrmw option to assembler if the
>> >> selected device has rmw instructions. I'll send a patch for gcc as
>> >> Please review the attached patch and give your suggestions.
>> > Hi,
>> > I have updated the patch to include -mrmw option to binutils.
>> Where is the patch ?
> Sorry, now I have attached the patch.
> 2014-03-27 Pitchumani Sivanupandi <email@example.com>
> * config/tc-avr.c: Add specified_mcu variable for selected mcu.
> (enum options): add OPTION_ISA_RMW for -mrmw option.
> (struct option md_longopts): Add mrmw option.
> (md_show_usage): add -mrmw option description.
> (md_parse_option): Update isa details if -mrmw option specified.
> * doc/c-avr.texi: Add doc for new option -mrmw.
> 2014-02-27 Pitchumani Sivanupandi <firstname.lastname@example.org>
> * gas/avr/avr.exp: Run new tests for avr target.
> * gas/avr/rmw.d: Add test for additional ISA support.
> * gas/avr/rmw.s: Ditto.