This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Enable Windows --auto-image-base to take an argument
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: binutils at sourceware dot org
- Date: Tue, 18 Mar 2014 11:06:34 -0400
- Subject: Re: [PATCH] Enable Windows --auto-image-base to take an argument
- Authentication-results: sourceware.org; auth=none
- References: <20140317141715 dot GA7385 at ednor dot casa dot cgf dot cx> <20140317174053 dot GA6657 at ednor dot casa dot cgf dot cx> <20140318004614 dot GB13623 at bubble dot grove dot modra dot org>
On Tue, Mar 18, 2014 at 11:16:14AM +1030, Alan Modra wrote:
>On Mon, Mar 17, 2014 at 01:40:53PM -0400, Christopher Faylor wrote:
>> +static unsigned long pe_auto_image_base = 0x61500000;
>[snip]
>> - return 0x61300000 + ((hash << 16) & 0x0FFC0000);
>> + return pe_auto_image_base + ((hash << 16) & 0x0FFC0000);
>
>Was the magic number (613 to 615) change deliberate or is this a typo?
It was deliberate. That is actually an address which is supposed to
follow the Cygwin DLL but the DLL has grown large enough that a bump
was required.
cgf