This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add "--trampolines" option to allow assembler to relax out-of-range jumps


Hi Sterling,

On Thu, Mar 13, 2014 at 8:35 PM, Sterling Augustine
<augustine.sterling@gmail.com> wrote:
> On Thu, Mar 13, 2014 at 8:11 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>>
>> 2014-02-28  David Weatherford <weath@cadence.com>
>>             Max Filippov <jcmvbkbc@gmail.com>
>
> Hi Max and David,
>
> Thanks for this change. It is a good one and a long time in coming.
>
> Unfortunately, it quite doesn't follow gnu coding style and that should be
> fixed before I commit it.
>
> In particular, the opening brace in structs go on the next line.  It needs
> blank lines after local variable declarations, and the changelog entry
> should combine related entries (foo, bar, bat): New functions.
>
> Also, please spell out trampoline everywhere, as that will make searching
> the code easier.
>
> I know this pickiness can be annoying but the project requires this and I'm
> the gatekeeper.
>
> I recommend reading:
>
> http://www.gnu.org/prep/standards/standards.html

I wish there were checkpatch or something like that.

> But I do want this change to go in, so I'm happy to apply it with these
> small fixes.

Thanks for the review, I will send an updated v2.

-- 
Thanks.
-- Max


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]