This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Bug: gather/scatter accepts same registers in destination/src and index
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Michael Zolotukhin" <michael dot v dot zolotukhin at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 21 Jan 2014 08:53:15 +0000
- Subject: Re: Bug: gather/scatter accepts same registers in destination/src and index
- Authentication-results: sourceware.org; auth=none
- References: <CANtU078XuYEQ8AnKR2BQoRSSByKLAf_TrzdpjEO=4h09U524gQ at mail dot gmail dot com>
>>> On 21.01.14 at 08:31, Michael Zolotukhin <michael.v.zolotukhin@gmail.com> wrote:
> I looked at the bug, spotted by Jan:
>
> # destination and index the same being accepted
> vgatherqps ymm0{k1}, [eax+zmm0]
> vpgatherqd ymm0{k1}, [eax+zmm0]
>
> The patch is ready, and the remaining question is how to add
> corresponding tests. Should they be added to 'vgather-check.s',
> 'x86-64-vgather-check.s' or should they be placed separately? Also,
> this problem touches scatters as well, so in case we want to have a
> single file for these tests, it probably should be renamed. What do
> you think?
Extending that test seems reasonable to me (as it appears to
be about the respective constraints in AVX); renaming it to
sg-check or vsg-check would probably make sense, but in the
end the name of the test files isn't that important imo.
Jan