This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] NDS32/opcodes: Fix out-of-range integer constant
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Wei-cheng Wang <cole945 at gmail dot com>
- Cc: <binutils at sourceware dot org>, Kuan-Lin Chen <kuanlinchentw at gmail dot com>
- Date: Fri, 10 Jan 2014 20:32:37 +0000
- Subject: Re: [PATCH] NDS32/opcodes: Fix out-of-range integer constant
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1401032322370 dot 19368 at tp dot orcam dot me dot uk> <CAPmZyH4Q3skyDeTjdwfbRT7YWn-Ai3xBbg1Gz8V86Me964H5FA at mail dot gmail dot com>
On Sat, 4 Jan 2014, Wei-cheng Wang wrote:
> Thanks for reviewing nds32 port :)
You're welcome, building with --enable-targets=all can often be helpful.
> According to the table of c99 126.96.36.199 Integer constants,
> the type of 0x100000000 is already long long int,
> so it shouldn't matter whether LL is suffixed.
Indeed, this has changed from C90 that 4.3.2 defaulted to (`-std=c99'
gets rid of the message even with 4.3.2). So far binutils have required
to support being built with a C90 compiler I believe. Of course since
you've been using int64_t you need a compiler that has a `long long' type
or an equivalent on 32-bit hosts anyway, so a plain C90 compiler won't do.
But making such a small correction to support older versions of GCC is
still worth the trouble IMHO.
Thanks to both of you for taking care of this.