This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR ld/16322: ld fails to generate GNU_RELRO segment

On Thu, Jan 9, 2014 at 10:51 AM, Hans-Peter Nilsson
<> wrote:
>> From: "H.J. Lu" <>
>> Date: Thu, 9 Jan 2014 19:22:19 +0100
>> On Thu, Jan 9, 2014 at 8:41 AM, H.J. Lu <> wrote:
>> > It fails since cris doesn't define COMMONPAGESIZE
>> > so that -z relro is ignored.  You can add relro support
>> > to cris or I can skip this test for cris.
>> I checked in this patch to check if GNU_RELRO segment
>> is generated.  It fails for cris-linux:
> Well duh.  But why add new failures, isn't GNU_RELRO checking
> covered by the failing 16323 test-case?

I added it so that we can catch the case where we pad LOAD
segment for GNU_RELRO segment when there is another LOAD
segment after it. It happens for x86-64 NaCL target.

>> since cris-linux doesn't support relro.  We can either
>> ignore them for cris and add relro support to cris.
> Looks like a one-liner, but I have to wonder why

Good question.

> Also, ia64-linux will fail.
> brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]