This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch,ld testsuite] Support check_lto_shared_available
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Vidya Praveen <vidyapraveen at arm dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, Binutils <binutils at sourceware dot org>
- Date: Thu, 9 Jan 2014 09:03:00 -0800
- Subject: Re: [Patch,ld testsuite] Support check_lto_shared_available
- Authentication-results: sourceware.org; auth=none
- References: <20131218192043 dot GA27931 at e103625-lin dot cambridge dot arm dot com> <CAMe9rOqpdu8REc8YuE9zs1oYj_yFgYZfwD_7NK1DeCfxmvw=Ww at mail dot gmail dot com> <20140107193436 dot GA1018 at e103625-lin dot cambridge dot arm dot com> <CAMe9rOos3YygcOkV_b957LzwCGF4EYicPz3OeqF_eNpLNmbHfA at mail dot gmail dot com> <20140107200655 dot GC1018 at e103625-lin dot cambridge dot arm dot com>
On Tue, Jan 7, 2014 at 12:06 PM, Vidya Praveen <vidyapraveen@arm.com> wrote:
> On Tue, Jan 07, 2014 at 07:48:49PM +0000, H.J. Lu wrote:
>> OK. Thanks.
>
> Could you please apply it for me? Thanks.
Done.
Thanks.
H.J.
> VP.
>
>>
>> H.J.
>>
>> On Jan 7, 2014 1:34 PM, "Vidya Praveen" <vidyapraveen@arm.com<mailto:vidyapraveen@arm.com>> wrote:
>> On Wed, Dec 18, 2013 at 07:35:14PM +0000, H.J. Lu wrote:
>> > On Wed, Dec 18, 2013 at 11:20 AM, Vidya Praveen <vidyapraveen@arm.com<mailto:vidyapraveen@arm.com>> wrote:
>> > > Hello,
>> > >
>> > > This patch implements the check_lto_shared_available improvement suggested by
>> > > H.J.Lu<http://H.J.Lu>[1] as a part of fixing check_lto_available[2].
>> > >
>> > > In abstract, check_lto_available checks if the compiler supports LTO by creating
>> > > an executable while check_lto_shared_available checks for LTO support as well as
>> > > LTO shared library support. This is essentially the old implementation of
>> > > check_lto_available which has been recently modified but with the support for
>> > > cflags & ldflags from the board file.
>> > >
>> > > This patch also modifies lto.exp to use check_lto_shared_available.
>> > >
>> > > OK?
>> > >
>> > > [1] https://sourceware.org/ml/binutils/2013-12/msg00136.html
>> > > [2] https://sourceware.org/ml/binutils/2013-12/msg00132.html
>> > >
>> > > Tested for aarch64-none-elf, arm-none-eabi, arm-none-linux-gnueabihf and
>> > > x86_64-unknown-linux-gnu.
>> > >
>> > > Regards
>> > > VP
>> > >
>> > > ld/testsuite/ChangeLog:
>> > >
>> > > 2013-12-18 Vidya Praveen <vidyapraveen@arm.com<mailto:vidyapraveen@arm.com>>
>> > >
>> > > * lib/ld-lib.exp (check_lto_shared_available): New check.
>> > > * ld-plugin/lto.exp: Use check_lto_shared_available.
>> > >
>> >
>> >
>> > +# Returns true if the target compiler supports LTO
>> >
>> > Please mention "-shared".
>> >
>> > + set status [remote_exec host $CC "$flags -shared
>> > -B[pwd]/tmpdir/ld/ -flto -fuse-linker-plugin $src -o $output"]
>> >
>> > Please add -fPIC.
>>
>> Sorry for the delay. Attached patch has the changes suggested.
>>
>> Tested for aarch64-none-elf, arm-none-eabi, arm-none-linux-gnueabihf and
>> x86_64-unknown-linux-gnu.
>>
>> OK?
>>
>> Regards
>> VP
>>
>> ld/testsuite/ChangeLog:
>>
>> 2014-01-07 Vidya Praveen <vidyapraveen@arm.com<mailto:vidyapraveen@arm.com>>
>>
>> * lib/ld-lib.exp (check_lto_shared_available): New check.
>> * ld-plugin/lto.exp: Use check_lto_shared_available.
>>
>
--
H.J.