This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: binutils-2.24 and HEAD: patch for gas/config/tc-i386.c
- From: Thomas Klausner <tk at giga dot or dot at>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 7 Jan 2014 11:39:36 +0100
- Subject: Re: binutils-2.24 and HEAD: patch for gas/config/tc-i386.c
- Authentication-results: sourceware.org; auth=none
- References: <20140106192333 dot GG14484 at danbala dot tuwien dot ac dot at> <sfid-H20140107-113525-+021 dot 87-1 at spamfilter dot osbf dot lua> <52CBE1C20200007800110FC9 at nat28 dot tlf dot novell dot com>
On Tue, Jan 07, 2014 at 10:15:14AM +0000, Jan Beulich wrote:
> >>> On 06.01.14 at 20:23, Thomas Klausner <tk@giga.or.at> wrote:
> > Hi!
> >
> > When compiling binutils-2.24 on NetBSD-6.99.28/amd64 with
> > clang-3.4rc1, the build stops in gas/config/tc-i386.c:
> >
> > config/tc-i386.c:1668:32: error: unused variable 'regbnd'
> > [-Werror,-Wunused-const-variable]
> > static const i386_operand_type regbnd = OPERAND_TYPE_REGBND;
> > ^
> > config/tc-i386.c:1669:32: error: unused variable 'vec_disp8'
> > [-Werror,-Wunused-const-variable]
> > static const i386_operand_type vec_disp8 = OPERAND_TYPE_VEC_DISP8;
> > ^
> >
> > The attached patch comments out these variables, but perhaps they
> > should be used instead? I don't know, so I thought I'd just report
> > this issue.
>
> Commenting them out (and even with C++ style comments) is surely
> not the right thing - they indeed look to be unused, so they should
> just get deleted.
Please do that then, I don't have write access to the repository ('//' is
C99 btw).
Thomas