This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Mips target in gold - part 3
- From: Cary Coutant <ccoutant at google dot com>
- To: Sasa Stankovic <Sasa dot Stankovic at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "iant at google dot com" <iant at google dot com>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Fri, 20 Dec 2013 16:12:27 -0800
- Subject: Re: Mips target in gold - part 3
- Authentication-results: sourceware.org; auth=none
- References: <7EDC79CE48A9944A88968ABABE6038EE22803419 at BADAG02 dot ba dot imgtec dot org> <CAHACq4p0NPEV9H9dgLsNW1F28R1eHjPwhj3TZz0Y_P0j8sfqfQ at mail dot gmail dot com> <7EDC79CE48A9944A88968ABABE6038EE228035F9 at BADAG02 dot ba dot imgtec dot org>
Sorry it's taken me so long to review this patch. I'll start with the
smaller patches...
+2013-08-02 Sasa Stankovic <Sasa.Stankovic@imgtec.com>
+
+ * symtab.cc (Symbol_table::set_dynsym_indexes): Allow a target to set
+ dynsym indexes.
+ * target.h (Target::has_custom_set_dynsym_indexes): New function.
+ (Target::set_dynsym_indexes): New function.
--- a/gold/symtab.cc
+++ b/gold/symtab.cc
@@ -2369,6 +2369,25 @@ Symbol_table::set_dynsym_indexes(unsigned int index,
Versions* versions)
{
std::vector<Symbol*> as_needed_sym;
+ std::vector<Symbol*> dyn_symbols;
dyn_symbols should be local to the if-block below.
--- a/gold/target.h
+++ b/gold/target.h
@@ -37,6 +37,7 @@
#include "elfcpp.h"
#include "options.h"
#include "parameters.h"
+#include "stringpool.h"
You shouldn't need to include "stringpool.h". The set_dynsym_indexes
function takes a Stringpool*, so you only need a forward declaration
for class Stringpool.
This patch is OK with those changes.
-cary