This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR binutils/16318: Objcopy loses EI_OSABI
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 17 Dec 2013 11:49:37 -0800
- Subject: Re: PATCH: PR binutils/16318: Objcopy loses EI_OSABI
- Authentication-results: sourceware.org; auth=none
- References: <20131212224436 dot GA15572 at intel dot com> <20131212230633 dot GA15944 at intel dot com> <20131213160050 dot GA9443 at intel dot com> <20131213192553 dot GA31573 at intel dot com>
On Fri, Dec 13, 2013 at 11:25 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> On Fri, Dec 13, 2013 at 08:00:50AM -0800, H.J. Lu wrote:
>> On Thu, Dec 12, 2013 at 03:06:33PM -0800, H.J. Lu wrote:
>> > On Thu, Dec 12, 2013 at 02:44:36PM -0800, H.J. Lu wrote:
>> > > Hi,
>> > >
>> > > I checked in this patch to copy EI_OSABI field. Those Linux targets
>> > > which define copy_private_bfd_data may fail binutils-all/strip-10.d.
>> > > I will submit a separate patch for them.
>> > >
>> >
>> > Here is a patch to call _bfd_elf_copy_private_bfd_data. But
>> > there are 5 failures:
>> >
>> > build-alpha-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> > build-crisv32-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> > build-frv-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> > build-ia64-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> > build-m68k-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> >
>> > since those targets don't use _bfd_elf_set_osabi. Shouldn't
>> > elf_backend_post_process_headers be set to _bfd_elf_set_osabi by
>> > default?
>> >
>> >
>>
>> Here is the pdated patch.
>>
>>
>
> Here is the updated patch without elf64-sh64.c change.
>
>
> H.J.
> ---
> bfd/
>
> 2013-12-13 H.J. Lu <hongjiu.lu@intel.com>
>
> PR binutils/16318
> * elf32-arm.c (elf32_arm_copy_private_bfd_data): Call
> _bfd_elf_copy_private_bfd_data.
> * elf32-bfin.c (bfin_elf_copy_private_bfd_data): Removed.
> (elf32_bfinfdpic_copy_private_bfd_data): Likewise.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-frv.c (frv_elf_copy_private_bfd_data): Removed.
> (elf32_frvfdpic_copy_private_bfd_data): Likewise.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-iq2000.c (iq2000_elf_copy_private_bfd_data): Removed.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-lm32.c (lm32_elf_copy_private_bfd_data): Removed.
> (lm32_elf_fdpic_copy_private_bfd_data): Call
> _bfd_elf_copy_private_bfd_data.
> * elf32-mep.c (mep_elf_copy_private_bfd_data): Removed.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-msp430.c (elf32_msp430_copy_private_bfd_data): Removed.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-mt.c (mt_elf_copy_private_bfd_data): Removed.
> (bfd_elf32_bfd_copy_private_bfd_data): Don't define.
> * elf32-sh.c (sh_elf_set_private_flags): Removed.
> (sh_elf_copy_private_data): Call _bfd_elf_copy_private_bfd_data
> and sh_elf_set_mach_from_flags.
> * elfnn-aarch64.c (elfNN_aarch64_copy_private_bfd_data): Removed.
> (bfd_elfNN_bfd_copy_private_bfd_data): Don't define.
>
I checked it in.
--
H.J.