This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: Default elf_backend_post_process_headers to set OSABI

On Thu, Dec 12, 2013 at 7:29 PM, Hans-Peter Nilsson
<> wrote:
>> From: "H.J. Lu" <>
>> Date: Fri, 13 Dec 2013 00:06:33 +0100
>> On Thu, Dec 12, 2013 at 02:44:36PM -0800, H.J. Lu wrote:
>> Here is a patch to call _bfd_elf_copy_private_bfd_data.  But
>> there are 5 failures:
>> build-alpha-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> build-crisv32-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> build-frv-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> build-ia64-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
>> build-m68k-linux/binutils/binutils.log:FAIL: strip on STB_GNU_UNIQUE
> My autotester sees failures for mipsisa32r2el-unknown-linux-gnu,
> cris-axis-linux-gnu, cris-axis-elf.  While the last two would
> see the same as your "build-crisv32-linux" the first one seems
> missing from your list.
>> since those targets don't use _bfd_elf_set_osabi.  Shouldn't
>> elf_backend_post_process_headers be set to _bfd_elf_set_osabi by
>> default?
> I'd guess yes?
> brgds, H-P

Here is a patch to do that.  OK to install?

2013-12-13  H.J. Lu  <>

    * elf-bfd.h (_bfd_elf_set_osabi): Renamed to ...
    (_bfd_elf_post_process_headers): This.
    * elf.c (_bfd_elf_compute_section_file_positions): Always
    call elf_backend_post_process_headers.
    (_bfd_elf_set_osabi): Renamed to ...
    (_bfd_elf_post_process_headers): This.
    * elf32-hppa.c (elf_backend_post_process_headers): Removed.
    * elf32-i370.c (elf_backend_post_process_headers): Likewise.
    * elf32-msp430.c (elf_backend_post_process_headers): Likewise.
    * elf32-ppc.c (elf_backend_post_process_headers): Likewise.
    * elf32-sparc.c (elf_backend_post_process_headers): Likewise.
    * elf64-hppa.c (elf_backend_post_process_headers): Likewise.
    * elf64-ppc.c (elf_backend_post_process_headers): Likewise.
    * elf64-sparc.c (elf_backend_post_process_headers): Likewise.
    * elf64-x86-64.c (elf_backend_post_process_headers): Likewise.
    *  (elf_backend_post_process_headers): Likewise.
    *  (elf_backend_post_process_headers): Likewise.
    * elf32-i386.c (elf_backend_post_process_headers): Don't
    define as _bfd_elf_set_osabi.
    (elf_i386_fbsd_post_process_headers): Updated.
    * elf32-mips.c (elf_fbsd_post_process_headers): Removed.
    (elf_backend_post_process_headers): Likewise.
    * elf32-tic6x.c (elf32_tic6x_set_osabi): Removed.
    (elf_backend_post_process_headers): Likewise.
    * elf64-mips.c (elf_fbsd_post_process_headers): Removed.
    (elf_backend_post_process_headers): Likewise.
    * elfn32-mips.c (elf_fbsd_post_process_headers): Removed.
    (elf_backend_post_process_headers): Likewise.
    * elfnn-aarch64.c (elfNN_aarch64_post_process_headers): Updated.
    * elfxx-target.h (elf_backend_post_process_headers): Default
    to _bfd_elf_post_process_headers.

Attachment: 0001-Default-elf_backend_post_process_headers-to-_bfd_elf.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]