This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] Use $(INSTALL_PROGRAM_ENV) consistently.
- From: Alan Modra <amodra at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 11 Dec 2013 09:48:36 +1030
- Subject: Re: [PATCH] Use $(INSTALL_PROGRAM_ENV) consistently.
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhqrR2V98gT7K=fng_nctmnQoJnN-5+aW+eCLQcDoD5tGQ at mail dot gmail dot com>
On Tue, Dec 10, 2013 at 02:13:39PM -0800, Roland McGrath wrote:
> When doing a cross-compile and 'make install-strip', it's necessary to
> prepend $(INSTALL_PROGRAM_ENV) to every invocation of $(INSTALL_PROGRAM)
> (or its libtool-wrapped equivalent). Otherwise you don't pass down the
> STRIPPROG setting that makes install-sh use the right strip command. The
> Automake-generated rules do this, but we unfortunately have several places
> where we've hand-copied and slightly tweaked those rules, and probably that
> was done before $(INSTALL_PROGRAM_ENV) was introduced.
> This fixes it in the straightforward way, though we're still subject to
> future bit rot. In future, probably the better solution is to nix the
> special rules and just let Automake handle all the binaries, using just:
> transform = s/-new$$//;$(program_transform_name)
> to make the standard rules handle the renaming.
> OK for trunk and 2.24?
Thanks! OK for trunk, Tristan has the say on the branch.
Australia Development Lab, IBM