This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- From: Cary Coutant <ccoutant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, Binutils <binutils at sourceware dot org>
- Date: Fri, 22 Nov 2013 15:40:01 -0800
- Subject: Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- Authentication-results: sourceware.org; auth=none
- References: <20131117165613 dot GA17622 at intel dot com> <20131117183518 dot GA5067 at intel dot com> <CAHACq4pwai-ZTWg1EgxhBpZwiPLBrwiMGq-Rh2cZ_feS4590MQ at mail dot gmail dot com> <CAMe9rOoP+AjEEm6dgTqYX4myyDFX-KNYOYR9+Zyv6nUMAGgtQg at mail dot gmail dot com>
>> The -madd-bnd-prefix option only works with a very recent assembler.
>> These last two rules should have gcctestdir/as as a dependency so that
>> the compiles will pick up the in-tree assembler. Alternatively, we
>> could add a configure check for the -madd-bnd-prefix option, and make
>> this test case conditional. I'd prefer the former -- your thoughts?
>
> Either works for me. Sorry for inconvenience.
OK, I'm committing the following patch.
-cary
2013-11-22 Cary Coutant <ccoutant@google.com>
gold/
* testsuite/Makefile.am (exception_x86_64_bnd_test): Use in-tree
assembler.
* testsuite/Makefile.in: Regenerate.
diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 2b7b5ae..aca9df8 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -2263,9 +2263,9 @@ exception_x86_64_bnd_test_DEPENDENCIES =
exception_x86_64_bnd_1.o \
exception_x86_64_bnd_2.o
exception_x86_64_bnd_test_LDFLAGS = $(exception_test_LDFLAGS)
exception_x86_64_bnd_test_LDADD = $(exception_x86_64_bnd_test_DEPENDENCIES)
-exception_x86_64_bnd_1.o: exception_test_1.cc
+exception_x86_64_bnd_1.o: exception_test_1.cc gcctestdir/as
$(CXXCOMPILE) -c -fpic -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ $<
-exception_x86_64_bnd_2.o: exception_test_2.cc
+exception_x86_64_bnd_2.o: exception_test_2.cc gcctestdir/as
$(CXXCOMPILE) -c -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ $<
endif DEFAULT_TARGET_X86_64