This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] implement correct alignment for Mach-O archive entries


On Oct 29, 2013, at 7:15 PM, Nathan Froyd <froydnj@mozilla.com> wrote:

> ----- Original Message -----
>> On Oct 29, 2013, at 10:54 AM, Nathan Froyd <froydnj@mozilla.com> wrote:
>> 
>>> +  if (bfd_get_flavour (abfd) == bfd_target_mach_o_flavour)
>>> +    ptr += ptr % 4;
>>> +  else
>> 
>> That does not pad to 4.
> 
> Ah, it doesn't quite.  We probably get lucky in that PTR is always even,
> where that formula does work.

This is OK for the darwin part, but you need a global maintainer OK for archive.c

Thanks,
Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]