This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH]: Add a LEXLIB variable in binutils/Makefile
- From: Tristan Gingold <gingold at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "binutils\ at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Wed, 18 Sep 2013 12:32:39 +0200
- Subject: Re: [PATCH]: Add a LEXLIB variable in binutils/Makefile
- Authentication-results: sourceware.org; auth=none
- References: <E77E159A-027A-4850-8190-0E66F66C0751 at adacore dot com> <87ioy8f5rf dot fsf at fleche dot redhat dot com>
On Sep 11, 2013, at 4:31 AM, Tom Tromey <email@example.com> wrote:
>>>>>> "Tristan" == Tristan Gingold <firstname.lastname@example.org> writes:
> Tristan> strangely enough, there are many occurrences to @LEXLIB@ in
> Tristan> binutils/Makefile.am.
> Let me say that it is definitively the preferred style to use $(LEXLIB)
> and not @LEXLIB@.
I think nobody disagree here :-)
> Tristan> This patch simply replaces them by $(LEXLIB) (It also defines
> Tristan> LEXLIB for homogeneity although it appears to be not required).
> It is really not needed. Automake automatically defines all the
> AC_SUBSTed variables.
Yes, that's correct. However I followed the current style: define
variables read. Minor point, I suppose.