This is the mail archive of the
mailing list for the binutils project.
Re: PR 15891 infrastructure
- From: Alan Modra <amodra at gmail dot com>
- To: Stephan Schreiber <info at fs-driver dot org>
- Cc: binutils at sourceware dot org
- Date: Mon, 2 Sep 2013 11:47:21 +0930
- Subject: Re: PR 15891 infrastructure
- Authentication-results: sourceware.org; auth=none
- References: <20130829102508 dot Horde dot d0IS54rYyUQR0ROUwAqs4w2 at webmail dot df dot eu>
On Thu, Aug 29, 2013 at 10:25:08AM +0200, Stephan Schreiber wrote:
> I invested some time in order to get a fix for bug 15891.
> I tried to implement the --as-needed functionality with two passes
> in (in the function elf_link_add_object_symbols() in bfd/elflink.c).
> The first pass just performs some processing in order to figure out
> whether the object is needed or nor. A roll back is performed in any
> way after that.
> The second pass performs the real processing if needed.
I've said before that I probably should have implemented --as-needed
as two passes over the new object symbols, so the fact you're
attempting a two-pass solution is good in my opinion. However, a
proper two-pass solution should not have any rollback code. Half
measures don't really make sense.
Australia Development Lab, IBM