This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] use only one-byte nops for linker code fill on x86 NaCl targets
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 26 Aug 2013 15:16:28 -0700
- Subject: Re: [PATCH] use only one-byte nops for linker code fill on x86 NaCl targets
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhrYxEo8X3psX=ATM7nTY71vZsc=czJohcSW5oGEb6gYqA at mail dot gmail dot com>
On Mon, Aug 26, 2013 at 2:58 PM, Roland McGrath <firstname.lastname@example.org> wrote:
> For x86 NaCl, no instruction may straddle a 32-byte alignment boundary.
> Since the bfd_arch_info_type.fill hook doesn't know the address where
> the fill will go (and hence its alignment), the only safe thing it can
> do is use only the one-byte nop instruction in the fill.
> I found it distressing that creating a whole new CPU variant appears
> to be the only way to make the function for code fill target-specific,
> but the notion of the variants and their names does not appear to have
> any other actual effect.
> OK for trunk?
It is OK.