Re: [PATCH, ARM]: Fix SB group relocations

[John Tytgat <john at bass-software dot com>]

In message <4617da7153.Jo@hobbes.bass-software.com>
          John Tytgat <john@bass-software.com> wrote:

> I recreated the patch and also corrected a problem which I found out in
> the meanwhile : when using an unresolved symbol for the SB group relocation
> there was an ICE as the section containing that symbol is NULL.  Hence
> the added test on sym_sec in elf32_arm_final_link_relocation.
> I also added a specific unresolved failure test for this.

In the meanwhile Nick already applied my first patch which was not taking
Richard's comments into account.  Basically this following up patch
addresses this by swapping the ld-arm/group-relocs-ldr(s)-bad(-2) tests
and also fixes the above mentioned problem with unresolved symbols
in a sb group relocation.

bfd

John Tytgat  <john@bass-software.com>

	* elf32-arm.c (elf32_arm_final_link_relocate): Handle
	unresolved symbol case for sb group relocations.

ld/testsuite

John Tytgat  <john@bass-software.com>

	* ld-arm/unresolved-2.d: New.
	* ld-arm/unresolved-2.s: New.
	* ld-arm/arm-elf.exp: Add the new test.
	* ld-arm/group-relocs-ldr-bad-2.d: Swap with...
	* ld-arm/group-relocs-ldr-bad.d: ...this.
	* ld-arm/group-relocs-ldr-bad-2.s: Swap with...
	* ld-arm/group-relocs-ldr-bad.s: ...this.
	* ld-arm/group-relocs-ldrs-bad-2.d: Swap with...
	* ld-arm/group-relocs-ldrs-bad.d: ...this.
	* ld-arm/group-relocs-ldrs-bad-2.s: Swap with...
	* ld-arm/group-relocs-ldrs-bad.s: ...this.

Thanks,
John.
-- 
John Tytgat                                                             BASS
John@bass-software.com

Attachment: arm_sb_g_reloc_v3.patch
Description: Text document