This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED PATCH] add new relocs to s390.c

On 12/07/13 22:40, Roland McGrath wrote:
> In this change:
> 	2013-07-05  Andreas Krebbel  <>
> 		* elf32-s390.c: Add new relocation definitions R_390_PC12DBL,
> 		R_390_PLT12DBL, R_390_PC24DBL, and R_390_PLT24DBL.
> 		(elf_s390_reloc_type_lookup, elf_s390_check_relocs)
> 		(elf_s390_gc_sweep_hook, elf_s390_relocate_section): Support new
> 		relocations.
> 		* elf64-s390.c: See elf32-s390.c
> 		* bfd-in2.h: Add new relocs to enum bfd_reloc_code_real.
> 		* libbfd.h: Add new reloc strings.
> Andreas apparently hand-editted bfd-in2.h and libbfd.h, which are generated
> files.  The source of truth is reloc.c.  So now if one has configured with
> --enable-maintainer-mode, or just does 'make -C bfd headers' in a build
> directory, they get regenerated without those changes and the build breaks
> (if s390 targets are enabled).
> Both those files start with a "DO NOT EDIT!" scare comment, so I'm not sure
> what else we should do to avoid this kind of mistake in the future.

Nothing else should be needed. I just need to be more careful. Sorry for that!



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]