This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Don't align text/data/bss sections in x86 assembler

On Tue, Jun 4, 2013 at 9:12 AM, H.J. Lu <> wrote:
> I prefer to disable them for NACL and add new tests for NACL.

Why?  I don't see how the address constants are material to the size tests.

> Before my changes, I see
> FAIL: TLS -fno-pic -shared
> FAIL: ld-size/size32-1-i386
> FAIL: ld-size/size32-1-x32
> FAIL: ld-size/size32-1-x86-64
> FAIL: ld-size/size32-2-i386
> FAIL: ld-size/size32-2-x32
> FAIL: ld-size/size32-2-x86-64
> FAIL: ld-size/size32-3-x32
> FAIL: ld-size/size32-3-x86-64
> FAIL: ld-size/size64-1-x32
> FAIL: ld-size/size64-1-x86-64
> FAIL: ld-size/size64-2-x32
> FAIL: ld-size/size64-2-x86-64
> FAIL: TLS -fpic -shared transitions
> FAIL: TLS descriptor -fpic -shared transitions
> FAIL: TLS -fpic and -fno-pic exec transitions
> FAIL: TLS descriptor -fpic and -fno-pic exec transitions
> FAIL: ld-x86-64/ilp32-4-nacl
> I checked in this patch to fix 2 extra failures
> caused by my alignment change.

Thanks for fixing the regression.  I'll deal with the others at some point.
For now, the x86 NaCl targets are not my highest priority.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]