This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[mips, committed] Tweak copy and jump-slot howtos
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: binutils at sourceware dot org
- Date: Sat, 04 May 2013 10:33:16 +0100
- Subject: [mips, committed] Tweak copy and jump-slot howtos
This patch makes all MIPS relocs use _bfd_mips_elf_generic_reloc
instead of bfd_elf_generic_reloc. The only ones that didn't were
R_MIPS_COPY and R_MIPS_JUMP_SLOT, which work fine either way.
I just thought it would be better to be consistent.
Tested on various targets and applied.
Richard
bfd/
* elf32-mips.c (elf_mips_copy_howto, elf_mips_jump_slot_howto):
Use _bfd_mips_elf_generic_reloc instead of bfd_elf_generic_reloc.
* elfn32-mips.c: Likewise.
* elf64-mips.c: Likewise.
Index: bfd/elf32-mips.c
===================================================================
--- bfd/elf32-mips.c 2013-05-04 09:48:56.411954266 +0100
+++ bfd/elf32-mips.c 2013-05-04 09:56:20.237184775 +0100
@@ -1515,7 +1515,7 @@ static reloc_howto_type elf_mips_copy_ho
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_COPY", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */
@@ -1531,7 +1531,7 @@ static reloc_howto_type elf_mips_jump_sl
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_JUMP_SLOT", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */
Index: bfd/elfn32-mips.c
===================================================================
--- bfd/elfn32-mips.c 2013-05-04 09:48:56.411954266 +0100
+++ bfd/elfn32-mips.c 2013-05-04 09:56:42.625381466 +0100
@@ -2597,7 +2597,7 @@ static reloc_howto_type elf_mips_copy_ho
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_COPY", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */
@@ -2613,7 +2613,7 @@ static reloc_howto_type elf_mips_jump_sl
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_JUMP_SLOT", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */
Index: bfd/elf64-mips.c
===================================================================
--- bfd/elf64-mips.c 2013-05-04 09:48:56.411954266 +0100
+++ bfd/elf64-mips.c 2013-05-04 09:57:02.128553102 +0100
@@ -2632,7 +2632,7 @@ static reloc_howto_type elf_mips_copy_ho
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_COPY", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */
@@ -2648,7 +2648,7 @@ static reloc_howto_type elf_mips_jump_sl
FALSE, /* pc_relative */
0, /* bitpos */
complain_overflow_bitfield, /* complain_on_overflow */
- bfd_elf_generic_reloc, /* special_function */
+ _bfd_mips_elf_generic_reloc, /* special_function */
"R_MIPS_JUMP_SLOT", /* name */
FALSE, /* partial_inplace */
0x0, /* src_mask */