This is the mail archive of the
mailing list for the binutils project.
Re: PATCH: PR ld/15371: uninitialised ifunc symbol
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 17 Apr 2013 09:23:49 -0700
- Subject: Re: PATCH: PR ld/15371: uninitialised ifunc symbol
- References: <20130415211356 dot GA980 at intel dot com> <CANu=DmiZT7U=Ky9s2-iorZmsSLykRkASAa-7Mdk5zsRzm86NdA at mail dot gmail dot com>
On Tue, Apr 16, 2013 at 1:24 AM, Will Newton <email@example.com> wrote:
> On 15 April 2013 22:13, H.J. Lu <firstname.lastname@example.org> wrote:
>> non_got_ref may not be set when building shared library. We need to set
>> non_got_ref if there are any non-PIC relocations. But we only did this
>> when there were no PLT/GOT relocations. It failed when there is a PLT
>> relocation. I am checking in this patch moves the non_got_ref check out.
> Hi H.J.,
> I noticed the code in elf-ifunc.c is only used by i386/x86_64. Is this
> code intended to be generic? Would it make sense for future IFUNC
> enabled ports to use it?
It is is supposed to be generic. But it may not be generic for
> Copyright is 2009 in that file so probably needs updating btw.
I checked in this patch to update it.
RCS file: /cvs/src/src/bfd/ChangeLog,v
retrieving revision 1.6029
diff -u -p -r1.6029 ChangeLog
--- ChangeLog 17 Apr 2013 14:16:00 -0000 1.6029
+++ ChangeLog 17 Apr 2013 16:21:47 -0000
@@ -1,3 +1,7 @@
+2013-04-17 H.J. Lu <email@example.com>
+ * elf-ifunc.c: Update copyright year.
2013-04-17 Luca Pizzamiglio <firstname.lastname@example.org>
* coffcode.h: Added a cast to void when a bfd_set_section_*()
RCS file: /cvs/src/src/bfd/elf-ifunc.c,v
retrieving revision 1.9
diff -u -p -r1.9 elf-ifunc.c
--- elf-ifunc.c 15 Apr 2013 21:16:18 -0000 1.9
+++ elf-ifunc.c 17 Apr 2013 16:21:47 -0000
@@ -1,5 +1,5 @@
/* ELF STT_GNU_IFUNC support.
- Copyright 2009
+ Copyright 2009-2013
Free Software Foundation, Inc.
This file is part of BFD, the Binary File Descriptor library.