This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch, AARCH64] gc-section tests for PLT related relocations
- From: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- To: binutils at sourceware dot org, Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Date: Tue, 09 Apr 2013 10:13:41 +0100
- Subject: Re: [Patch, AARCH64] gc-section tests for PLT related relocations
- References: <CAJK_mQ00=2AOBRj29eQTuJkfenH-qPxaOuU5_7N3b0v4-tWcRQ at mail dot gmail dot com> <CAFqB+Px1q7i7C-iomLe8xjADDRcUaWU23D5-T0q-3622o=Yqjw at mail dot gmail dot com> <CAJK_mQ0WkeX22+zvcmvEaWHTZ0fX+hUCPNXaXbfC1ANeoqP5+w at mail dot gmail dot com>
Hi,
Thanks, Couple more minor tweaks...
On 09/04/13 07:16, Venkataramanan Kumar wrote:
2013-04-09 Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
* ld-aarch64/gc-plt1.s: New gc section test.
New file.
* ld-aarch64/gc-plt2.s: Likewise
* ld-aarch64/gc-plt-hidden.s: Likewise
* ld-aarch64/gc-plt-main.s: Likewise
* ld-aarch64/gc-relocs-257.s: Likewise
* ld-aarch64/gc-plt-relocs.d: Update expected objdump
* ld-aarch64/gc-relocs-257.d: Likewise
* ld-aarch64/gc-relocs-257-dyn.d: Likewise
* ld-aarch64/aarch64-elf.exp: add tests
ChangeLog entries are full sentences therefore they start with a capital
and end with a period.
The patch contains a number of white space issues, could you go through
and remove all instances of trailing white space, space before tab etc.
Please use consistent layout in the assembler files, for example:
+++ src-patch/ld/testsuite/ld-aarch64/gc-plt2.s 2013-04-09
10:55:49.979419681 +0530
@@ -0,0 +1,12 @@
+.text
+ .align 2
TAB before .text
+++ src-patch/ld/testsuite/ld-aarch64/gc-relocs-257.s 2013-04-09
10:55:49.979419681 +0530
@@ -0,0 +1,8 @@
+.text
+.word tempy
+.xword tempy2
+.hword tempy3
+.hword tempy3+8
TAB before directives.
+
+ and x0,x0,x0
Space after comma.
Thanks
/Marcus