This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, AARCH64] gc-section tests for PLT related relocations


Hi Marcus,

I have updated your comments. Please find the revised patch attached.

if it is OK for trunk, please commit for me.

ChangeLog.

2013-04-09  Venkataramanan Kumar  <venkataramanan.kumar@linaro.org>
        * ld-aarch64/gc-plt1.s: New gc section test.
        * ld-aarch64/gc-plt2.s: Likewise
        * ld-aarch64/gc-plt-hidden.s: Likewise
        * ld-aarch64/gc-plt-main.s: Likewise
        * ld-aarch64/gc-relocs-257.s: Likewise
        * ld-aarch64/gc-plt-relocs.d: Update expected objdump
        * ld-aarch64/gc-relocs-257.d: Likewise
        * ld-aarch64/gc-relocs-257-dyn.d: Likewise
        * ld-aarch64/aarch64-elf.exp: add tests

regards,
Venkat.

On 8 April 2013 17:14, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> Hi,  Couple of comments....
>
>
>
> diff -urN src-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d
> src-plt-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d
> --- src-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d 1970-01-01
> 05:30:00.000000000 +0530
> +++ src-plt-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d 2013-04-03
> 11:50:02.562593137 +0530
> @@ -0,0 +1,48 @@
> +#source: gc-plt1.s
> +#source: gc-plt-main.s
> +#source: gc-plt-hidden.s
> +#source: gc-plt2.s
> +#ld: --gc-sections -T aarch64.ld --shared
> +#objdump: -dT
> +
> +# Shared object with plt related relocs against global symbol
> +# and local functions gced. After gc-section removal we are
>
> Double space after period (GNU coding style).
>
> +# checking that function does not exit
>
> exit -> exists.
>
> +
> +.*:     file format elf64-littleaarch64
>
> This also needs to handle BE.
>
> Cheers
> /Marcus
>
> On 3 April 2013 08:20, Venkataramanan Kumar
> <venkataramanan.kumar@linaro.org> wrote:
>> Hi Maintainers,
>>
>> This patch adds gc-section tests for PLT related aarch64 relocations
>> on top of the TLS and GOT tests that I posted last week.
>>
>> These additional tests are passing with make check for aarch64-none-linux-gnu.
>>
>> No regressions.
>>
>> The patch that covers TLS and GOT can be found here:
>> http://sourceware.org/ml/binutils/2013-03/msg00273.html
>>
>> If it is Ok for trunk, please commit on my behalf?
>>
>> regards,
>> Venkat.

Attachment: gc-plt-tests-updated.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]