This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] Fix sleb128 encoding for difference expressions
- From: Alan Modra <amodra at gmail dot com>
- To: Julian Brown <julian at codesourcery dot com>, binutils at sourceware dot org, clm at codesourcery dot com
- Date: Mon, 8 Apr 2013 16:09:44 +0930
- Subject: Re: [PATCH] Fix sleb128 encoding for difference expressions
- References: <20121108130512 dot 4991d16a at octopus> <509BC97B02000078000A73D9 at nat28 dot tlf dot novell dot com> <20121109175729 dot 795ff7d8 at octopus> <50A0BAFC02000078000A7A1A at nat28 dot tlf dot novell dot com> <20121112121918 dot 76e18240 at octopus> <20121119153757 dot 64572565 at octopus> <20121127152921 dot 6264be7d at octopus> <20130405170002 dot 32274b7c at octopus> <20130408050413 dot GA4102 at bubble dot grove dot modra dot org> <20130408062955 dot GA28916 at bubble dot grove dot modra dot org>
On Mon, Apr 08, 2013 at 03:59:55PM +0930, Alan Modra wrote:
> On Mon, Apr 08, 2013 at 02:34:13PM +0930, Alan Modra wrote:
> > On Fri, Apr 05, 2013 at 05:00:02PM +0100, Julian Brown wrote:
> > > > > On Mon, 12 Nov 2012 12:19:18 +0000
> > > > > Julian Brown <firstname.lastname@example.org> wrote:
> > > > > > This is a more conservative version of the patch, which *only*
> > > > > > affects assembly of .sleb128 directives.
> > That one was http://sourceware.org/ml/binutils/2012-11/msg00141.html
> > It still applies, but I see testsuite failures on x86_64-linux.
> > First one is:
> > regexp_diff match failure
> > regexp "^ 0000 7d2a0000 00000000 00000000 00000000 .*$"
> > line " 0000 7d2a }* "
> > FAIL: .sleb128 tests (2)
> > I'd suggest making the match
> > 0+ 7d2a.*
> > and similarly with other testcases.
> > Patch is OK with those changes.
> Oh, and another thing I just noticed, you need to ensure these tests
> are only run on ELF targets. Probably best to move them to
Oops, no, sorry. We do support .sleb128 on non-ELF. But AOUT for
instance typically won't have .data starting at zero for your
testcases.. So my suggestion to use 0+ wasn't quite correct.
Australia Development Lab, IBM