This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/15096: DT_RPATH != DT_RUNPATH


On Mon, Feb 04, 2013 at 03:20:00PM -0800, H.J. Lu wrote:
> Hi,
> 
> We can't replace DT_RPATH with DT_RUNPATH by default since one object's
> DT_RUNPATH entry does not affect the search for any other object's
> dependencies.  This patch enables new tdags on Linux only if -rpath
> isn't used.  OK to install?

OK, except

> 	PR ld/15096
> 	* bfdlink.h (bfd_link_info): Change new_dtags to int.

I think this would be better left as-is, and instead a new boolean
new_dtags_set variable used in elf32.em.  That way you won't need to
change bfd_link_info (and bump the BFD version).  Also, you neglected
to mention before_parse in the Changelog.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]