This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, AArch64] Add support for alias instructions SXTL, SXTL2, UXTL and UXTL2


On Jan 30, 2013, at 4:38 PM, Marcus Shawcroft wrote:

> On 30/01/13 14:27, Yufeng Zhang wrote:
>> On 01/30/13 13:12, nick clifton wrote:
>>> Hi Yufeng,
>>> 
>>>> include/opcode/
>>>> 2013-01-30  Yufeng Zhang<yufeng.zhang@arm.com>
>>>> 
>>>>       * aarch64.h (aarch64_op): Add OP_SXTL, OP_SXTL2, OP_UXTL and OP_UXTL2.
>>>> 
>>>> opcodes/
>>>> 2013-01-30  Yufeng Zhang<yufeng.zhang@arm.com>
>>>> 
>>>>       * aarch64-tbl.h (aarch64_opcode_table): Flag sshll, sshll2, ushll and
>>>>       ushll2 with F_HAS_ALIAS.  Add entries for sxtl, sxtl2, uxtl and uxtl2.
>>>>       * aarch64-asm.c (convert_xtl_to_shll): New function.
>>>>       (convert_to_real): Handle OP_SXTL, OP_SXTL2, OP_UXTL and OP_UXTL2 by
>>>>       calling convert_xtl_to_shll.
>>>>       * aarch64-dis.c (convert_shll_to_xtl): New function.
>>>>       (convert_to_alias): Handle OP_SXTL, OP_SXTL2, OP_UXTL and OP_UXTL2 by
>>>>       calling convert_shll_to_xtl.
>>>>       * aarch64-asm-2.c: Re-generate.
>>>>       * aarch64-dis-2.c: Re-generate.
>>>>       * aarch64-opc-2.c: Re-generate.
>>>> 
>>>> gas/testsuite/
>>>> 2013-01-30  Yufeng Zhang<yufeng.zhang@arm.com>
>>>> 
>>>>       * gas/aarch64/alias.s: Add new tests.
>>>>       * gas/aarch64/alias.d: Update.
>>>>       * gas/aarch64/no-aliases.d: Update.
>>> 
>>> Approved for mainline - please apply.
>> 
>> Thanks!  Is it OK for the 2.23 branch?  The patch is essentially a bug
>> fix, adding support for the missing alias instructions.
>> 
>> Thanks,
>> Yufeng
>> 
> 
> I agree, this fix adds missing support for an architectural alias.  The patch looks low risk, therefore I would like to see it included on the 2.23 branch.

Fine with me.  Please apply to the branch.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]