This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Performance bug while ordering .text sections by default in gold.

On Wed, Jan 23, 2013 at 3:06 PM, Ian Lance Taylor <> wrote:
> On Wed, Jan 23, 2013 at 2:50 PM, Sriraman Tallam <> wrote:
>> Attached new patch with the changes. Also added a new option to gold
>> "--notextreorder" to disable the default sorting.
>> +  DEFINE_bool(notextreorder, options::TWO_DASHES, '\0', false,
>> +           N_("Disable the default text section reordering where text "
>> +              "sections with prefixes .text{unlikely,exit,startup,hot}"
>> +              "are grouped"),
>> +           NULL);
> Please name the option text_reorder, and make it boolean with a
> default of true.  Also don't make the help text too long--take a look
> at the output of --help.  That is, something like
> DEFINE_bool(text_reorder, options::TWO_DASHES, '\0', true,
>     N_("Enable text section reordering for GCC section names"),
>     N_("Disable...."));
>> +      else if (strcmp (this->name(), ".text") == 0)
> No space before left parenthesis.
> This is OK with those changes.

Made those changes and also modified text_section_grouping to check if
--no-text-reorder does the right thing.


> Thanks.
> Ian

Attachment: section_ordering_bug.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]