This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFC 02/02 v2] Refactor PRPSINFO handling on GDB

On Thursday, January 10 2013, Pedro Alves wrote:

> The subject is a bit misleading, as this does more than
> just refactoring PRPSINFO handling; it dumps more fields
> as well.  Splitting the refactoring and the actual
> extending into separate patches, along with a short
> description of what's new in the cores would have been neat,
> but I'm coming back late to the party, and don't insist.

Wow, OK, sorry about that, it wasn't my intention.

Anyway, at first I thought that the extension could be seen as
refactoring as well, that's why I didn't bother making another patch.

>> +  /* Generating and copying the program's arguments.  `get_inferior_args'
>> +     may throw, but we want to continue the execution anyway.  */
>> +    {
>> +      infargs = get_inferior_args ();
>> +    }
>> +
> Hmm?  We were not doing that before.  What exception is that?

`get_inferior_args' calls `construct_inferior_arguments', which can call
`error' in an specific scenario (not STARTUP_WITH_SHELL, arguments that
contain spaces).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]