This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch, gas] Change 'internal Error' to 'internal error'

While working on another bug someone pointed out that the MIPS gnu assembler
was printing out 'internal Error' with a capital E in error instead of using
a small e in error.  Grepping through the gnu assembler source I found that
most uses were 'internal error' and not 'internal Error' so this patches
changes MIPS to match that standard.  I also found two places where the x86
assembler would use Error instead of error so I include that change too.

I see 'internal Error' in various po/* localization files too, should I be
regenerating those somehow?

OK to checkin?

Steve Ellcey

2013-01-08  Steve Ellcey  <>

	* config/tc-i386.c (md_begin): Change 'Error' to 'error'.
	* config/tc-mips.c (internalError): Ditto.

diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index a0680d3..f24868d 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -2375,7 +2375,7 @@ md_begin (void)
 				    (void *) core_optab);
 	    if (hash_err)
-		as_fatal (_("internal Error:  Can't hash %s: %s"),
+		as_fatal (_("internal error:  Can't hash %s: %s"),
 			  (optab - 1)->name,
@@ -2397,7 +2397,7 @@ md_begin (void)
 	hash_err = hash_insert (reg_hash, regtab->reg_name, (void *) regtab);
 	if (hash_err)
-	  as_fatal (_("internal Error:  Can't hash %s: %s"),
+	  as_fatal (_("internal error:  Can't hash %s: %s"),
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 2d8639c..4186bc6 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -1311,7 +1311,7 @@ static struct {
 /* Prototypes for static functions.  */
 #define internalError()							\
-    as_fatal (_("internal Error, line %d, %s"), __LINE__, __FILE__)
+    as_fatal (_("internal error, line %d, %s"), __LINE__, __FILE__)
 enum mips_regclass { MIPS_GR_REG, MIPS_FP_REG, MIPS16_REG };

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]