This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Testsuite de-Linuxification
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: <binutils at sourceware dot org>, Roland McGrath <mcgrathr at google dot com>
- Date: Mon, 7 Jan 2013 16:19:47 +0000
- Subject: Re: Testsuite de-Linuxification
- References: <87mwxftxmn.fsf@kepler.schwinge.homeip.net>
Thomas,
> I applied the following to fix some issues that crept in while I was not
> looking. Roland, based on surrounding code, at least the stack exec and
> stack size ones should probably be enabled for NACL, too?
>
> * ld-elf/elf.exp (stack exec, stack size): Run for any GNU target.
> * ld-elf/maxpage3c.d: Run for any x86 GNU target.
> * ld-elf/maxpage4.d: Likewise.
> * ld-elf/maxpage5.d: Likewise.
> * ld-i386/export-class.exp: Likewise.
>
[...]
> diff --git ld/testsuite/ld-i386/export-class.exp ld/testsuite/ld-i386/export-class.exp
> index cd96b4b..9dedd90 100644
> --- ld/testsuite/ld-i386/export-class.exp
> +++ ld/testsuite/ld-i386/export-class.exp
> @@ -29,9 +29,8 @@ if { ![is_elf_format] } {
> return
> }
>
> -# Exclude non-Linux targets; feel free to include your favorite one
> -# if you like.
> -if { ![istarget i?86-*-linux*] } {
> +if { !([istarget i?86-*-linux*]
> + || [istarget i?86-*-gnu*]) } {
> return
> }
>
I disagree with the removal of the comment (although a rewording would be
due of course), there are other x86 targets that use ELF shared libraries,
such as SCO OpenServer or Unixware, and that are likely to support export
classes. Someone who cares about such targets may be still interested in
adding them to this test case.
That said, I have since discovered the existence of the
check_shared_lib_support procedure -- perhaps we should simply use that
instead to relieve the maintainers (if any) of the more exotic platforms
from the burden of chasing such subtleties across the test suite.
Thoughts?
Maciej