This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] MIPS/BFD: Correct/clean up ELF FP attribute warning messages
"Maciej W. Rozycki" <firstname.lastname@example.org> writes:
> On Wed, 21 Nov 2012, Maciej W. Rozycki wrote:
>> > While you're changing the errors anyway, it might be worth replacing
>> > the two quoted options with %s and using -msoft-float and -mhard-float
>> > instead of "soft float" and "hard float". Hopefully that wins on user
>> > interface grounds (we consistently reference an option) and means we
>> > always use the same format string. Just a suggestion though.
>> Agreed, quoting the options makes sense to me and I didn't like these
>> "soft float" messages either, I just didn't feel motivated enough to think
>> what to do about them. ;)
> Additionally the delegation of option names into substituted strings
> removed the message variations, addressing your other concern. On the
> other hand the extra diagnostics provided for unknown attributes
> multiplied the original message into three. I hope this is a good
> trade-off overall though.
> So here's the final version, no regressions across the usual MIPS
> targets. OK to apply?