This is the mail archive of the
mailing list for the binutils project.
Re: PATCH: PR binutils/14813: Wrong return type for opncls_bclose
On Tue, Nov 06, 2012 at 09:34:23PM -0800, H.J. Lu wrote:
> On Tue, Nov 6, 2012 at 5:07 PM, Alan Modra <email@example.com> wrote:
> > On Tue, Nov 06, 2012 at 04:30:07PM -0800, H.J. Lu wrote:
> >> Hi,
> >> This patch changes return type of bclose to bfd_boolean. It fixes
> >> binutils/bfdtest2. OK to install?
> > Not without checking gdb code too.
> Sure. Here is the GDB patch. OK to install?
No, gdb is fine as is. When I saw your change I grepped for bfd_iovec
and hit a number of places in gdb, which is why I commented about
checking gdb. It turns out that none of these have anything to do
with your change to struct bfd_iovec.
Australia Development Lab, IBM