This is the mail archive of the
mailing list for the binutils project.
Re: PR 14067 - addr2line broken on x86_64-w64-mingw32
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: binutils Development <binutils at sourceware dot org>, Kai Tietz <ktietz at redhat dot com>
- Date: Tue, 6 Nov 2012 17:02:58 +0100
- Subject: Re: PR 14067 - addr2line broken on x86_64-w64-mingw32
- References: <A7733312-4DB7-4AF5-B9A3-4AD145ECC37B@adacore.com>
2012/11/6 Tristan Gingold <firstname.lastname@example.org>:
> Hi Kai,
> in the ChangeLog for PR binutils/14067, you have written:
> * coff-i386.c (_bfd_generic_find_nearest_line_discriminator):
> define as coff_find_nearest_line_discriminator.
> * libcoff-in.h (coff_find_nearest_line_discriminator): New
> * libcoff.h: Regenerated.
> * coff-x86_64.c: Likewise.
> But _bfd_generic_find_nearest_line_discriminator is not redefined in
> coff-x86_64.c, and therefore addr2line always fails to find the line.
> Fixed by the following patch. Ok for trunk ?
> 2012-11-06 Tristan Gingold <email@example.com>
> * coff-x86_64.c (_bfd_generic_find_nearest_line_discriminator):
> Define as coff_find_nearest_line_discriminator.
> diff --git a/bfd/coff-x86_64.c b/bfd/coff-x86_64.c
> index fc39f9f..1e31395 100644
> --- a/bfd/coff-x86_64.c
> +++ b/bfd/coff-x86_64.c
> @@ -731,6 +731,9 @@ coff_amd64_is_local_label_name (bfd *abfd, const char *name)
> #define amd64coff_object_p coff_object_p
> +#define _bfd_generic_find_nearest_line_discriminator \
> + coff_find_nearest_line_discriminator
> const bfd_target
> #ifdef TARGET_SYM
> TARGET_SYM =
Oh, yes. I missed that part on commit. I have the same in tree. I
would suggest to apply it as obvious.